-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3203: Fix depreciated
typo
#7834
CORS-3203: Fix depreciated
typo
#7834
Conversation
/cc @lleshchi |
/lgtm |
/retest Surely changing an error message (which is showing up correctly in the results) isn't causing bootstrap failures. |
Ugh, I may have to phone a friend here. @jcpowermac did I really break these two tests? Sorry, I don't know what to look for. /retest Cause why not? |
From https://en.wikipedia.org/wiki/Deprecation: "Not to be confused with [Depreciation](https://en.wikipedia.org/wiki/Depreciation)."
740df4a
to
99202bc
Compare
Just a rebase, gonna see if those tests will magically pass now. |
@2uasimojo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-vsphere-ovn |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@2uasimojo: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
depreciated
typodepreciated
typo
@2uasimojo: This pull request references CORS-3203 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@2uasimojo: This pull request references CORS-3203 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cd07b68
into
openshift:master
/cherry-pick release-4.15 |
@2uasimojo: new pull request created: #7912 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From https://en.wikipedia.org/wiki/Deprecation:
"Not to be confused with Depreciation."
CORS-3203