Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3203: Fix depreciated typo #7834

Merged

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Dec 13, 2023

@2uasimojo
Copy link
Member Author

/cc @lleshchi

@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 13, 2023
@2uasimojo
Copy link
Member Author

/retest

Surely changing an error message (which is showing up correctly in the results) isn't causing bootstrap failures.

@2uasimojo
Copy link
Member Author

Ugh, I may have to phone a friend here. @jcpowermac did I really break these two tests? Sorry, I don't know what to look for.

/retest

Cause why not?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@2uasimojo
Copy link
Member Author

Just a rebase, gonna see if those tests will magically pass now.

Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones 99202bc link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-zones-techpreview 99202bc link false /test e2e-vsphere-zones-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo 2uasimojo changed the title Fix depreciated typo CORS-3203 Fix depreciated typo Jan 15, 2024
@2uasimojo
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@2uasimojo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@2uasimojo 2uasimojo changed the title CORS-3203 Fix depreciated typo CORS-3203: Fix depreciated typo Jan 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2024

@2uasimojo: This pull request references CORS-3203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

From https://en.wikipedia.org/wiki/Deprecation:

"Not to be confused with Depreciation."

CORS-3203

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2024
@2uasimojo
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2024

@2uasimojo: This pull request references CORS-3203 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d208122 and 2 for PR HEAD 99202bc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7c75008 and 1 for PR HEAD 99202bc in total

@openshift-merge-bot openshift-merge-bot bot merged commit cd07b68 into openshift:master Jan 16, 2024
22 of 24 checks passed
@2uasimojo 2uasimojo deleted the deprecate-depreciate branch January 16, 2024 16:32
@2uasimojo
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@2uasimojo: new pull request created: #7912

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants