Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-871: baremetal: remove ironic tf files #8117

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

honza
Copy link
Member

@honza honza commented Mar 7, 2024

A few were accidentally left behind during the recent refactor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024

@honza: This pull request references METAL-871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

A few were accidentally left behind during the recent refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

A few were accidentally left behind during the recent refactor
@dtantsur
Copy link
Member

dtantsur commented Mar 7, 2024

level=error msg=Error: No value for required variable
level=error
level=error msg=  on variables-baremetal.tf line 11:
level=error msg=  11: variable "masters" { 

Still used or defined somewhere?

@honza
Copy link
Member Author

honza commented Mar 7, 2024

Still used or defined somewhere?

I deleted the masters var in the latest push.

@honza
Copy link
Member Author

honza commented Mar 7, 2024

Weird rpm mirror errors

/retest-required

@elfosardo
Copy link
Contributor

/retest

@dtantsur
Copy link
Member

dtantsur commented Mar 8, 2024

/test e2e-metal-ipi-ovn-dualstack
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack c336c01 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-sdn c336c01 link false /test e2e-metal-ipi-sdn
ci/prow/okd-e2e-aws-ovn-upgrade c336c01 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb
Copy link
Member

zaneb commented Mar 10, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Mar 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 55ff2a0 into openshift:master Mar 11, 2024
27 of 29 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403110313.p0.g55ff2a0.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants