tests/smoke/cluster_test.go: Drop unused networkingEnv #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
ok to test |
|
The Jenkins error was: retest this please |
|
@wking The error actually was |
The last consumer was commented out in ebe6961 (disable out of sync tests for opentonic, 2018-06-08, coreos/tectonic-installer#3270) and that comment was removed in 31eb165 (remove unused code, 2018-06-18, coreos/tectonic-installer#3298).
wking
force-pushed
the
smoke-test-drop-networking-env
branch
from
493834a
to
71735c0
Compare
|
retest this please |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/test yaml-lint |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 23, 2018
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Jan 31, 2022
* Continue using Yussuf's brnach of the terraform provider We're not able to switch to upstrem yet as his changes aren't in the openshift branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last consumer was commented out in ebe6961 (coreos/tectonic-installer#3270) and that comment was removed in 31eb165 (coreos/tectonic-installer#3298).
Spun off from #94 (which is itself spun off from #92) as I keep drilling down to get the smoke-test vendor directory cleaned up :p. Hopefully this change is scoped tightly enough to not cause any surprising breakage :p.