-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906397: Fix incorrect IPA option #131
Bug 1906397: Fix incorrect IPA option #131
Conversation
This issue managed to sneak in during the last rebase. Upstream: metal3-io#232
/retest |
This needs a BZ after feature freeze |
Can we maybe not overdo it with formalities for a trivial regression? |
If it's after FF, it needs a bug. I'm just the messenger. The bots will be enforcing it shortly, anyway. |
/hold |
Well, there aren't now, so you're enforcing it, tripling my work to fix a trivial thing... |
/shrug It takes a few minutes to a file a BZ once you know where to do it. Just do the right thing. |
Okay, I'll wait for someone to actually hit it and report a bugzilla. Also, what is wrong with the CI now? |
/retest |
/retitle Bug 1906397: Fix incorrect IPA option |
@dtantsur: This pull request references Bugzilla bug 1906397, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Feel free to remove the hold ( |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, dtantsur, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
@dtantsur: All pull requests linked via external trackers have merged: Bugzilla bug 1906397 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
export HTTP_PORT
This issue managed to sneak in during the last rebase.
Upstream: metal3-io#232