Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1906397: Fix incorrect IPA option #131

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Dec 9, 2020

This issue managed to sneak in during the last rebase.

Upstream: metal3-io#232

This issue managed to sneak in during the last rebase.

Upstream: metal3-io#232
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@dtantsur
Copy link
Member Author

dtantsur commented Dec 9, 2020

/retest

@stbenjam
Copy link
Member

stbenjam commented Dec 9, 2020

This needs a BZ after feature freeze

@dtantsur
Copy link
Member Author

dtantsur commented Dec 9, 2020

This needs a BZ after feature freeze

Can we maybe not overdo it with formalities for a trivial regression?

@stbenjam
Copy link
Member

stbenjam commented Dec 9, 2020

This needs a BZ after feature freeze

Can we maybe not overdo it with formalities for a trivial regression?

If it's after FF, it needs a bug. I'm just the messenger. The bots will be enforcing it shortly, anyway.

@stbenjam
Copy link
Member

stbenjam commented Dec 9, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@dtantsur
Copy link
Member Author

dtantsur commented Dec 9, 2020

The bots will be enforcing it shortly, anyway.

Well, there aren't now, so you're enforcing it, tripling my work to fix a trivial thing...

@stbenjam
Copy link
Member

stbenjam commented Dec 9, 2020

/shrug

It takes a few minutes to a file a BZ once you know where to do it. Just do the right thing.

@openshift-ci-robot openshift-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Dec 9, 2020
@dtantsur
Copy link
Member Author

dtantsur commented Dec 9, 2020

Okay, I'll wait for someone to actually hit it and report a bugzilla.

Also, what is wrong with the CI now?

@stbenjam
Copy link
Member

stbenjam commented Dec 9, 2020

/retest

@stbenjam
Copy link
Member

/retitle Bug 1906397: Fix incorrect IPA option

@openshift-ci-robot openshift-ci-robot changed the title Fix incorrect IPA option Bug 1906397: Fix incorrect IPA option Dec 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 10, 2020
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Bugzilla bug 1906397, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906397: Fix incorrect IPA option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

stbenjam commented Dec 10, 2020

/lgtm

Feel free to remove the hold (/ hold cancel) when CI is fixed. I left it so the bots don't keep trying to retest it over and over again.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, dtantsur, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bfournie,dtantsur,stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtantsur
Copy link
Member Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@stbenjam
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit e44ccc3 into openshift:master Dec 10, 2020
@openshift-ci-robot
Copy link

@dtantsur: All pull requests linked via external trackers have merged:

Bugzilla bug 1906397 has been moved to the MODIFIED state.

In response to this:

Bug 1906397: Fix incorrect IPA option

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot pushed a commit to openshift-bot/ironic-image that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants