Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom deploy: do not log the pull secret #196

Merged
merged 1 commit into from Jul 23, 2021

Conversation

dtantsur
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from bfournie and zaneb July 21, 2021 15:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@sadasu
Copy link

sadasu commented Jul 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu
Copy link

sadasu commented Jul 21, 2021

/hold
We want #190 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@elfosardo
Copy link

/retest

1 similar comment
@elfosardo
Copy link

/retest

@dtantsur
Copy link
Member Author

/hold cancel

The metal3 sync has merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@iurygregory
Copy link

/recheck

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@dtantsur
Copy link
Member Author

/retest-required

@dtantsur
Copy link
Member Author

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation
/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

The actual jobs have passed, and this file is not used in the CI anyway.

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/prevalidation-e2e-metal-ipi-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation
/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

The actual jobs have passed, and this file is not used in the CI anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-virtualmedia

Pointless retesting. This file is still not used anywhere.

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/e2e-metal-ipi, ci/prow/e2e-metal-ipi-virtualmedia

In response to this:

/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-metal-ipi-virtualmedia

Pointless retesting. This file is still not used anywhere.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0898005 into openshift:master Jul 23, 2021
@dtantsur dtantsur deleted the no-log-secret branch July 23, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants