Merge from upstream metal3-io/ironic-image #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dtantsur
commented
Aug 11, 2022
dtantsur
commented
- Add option to to listen on single inspector interface when inspector running without reverse proxy
- Move hardys to emeritus_approvers
- Pin Werkzeug to 2.1.2 until newer version of sushy-tools is out
- Update sushy-tools to version 0.20.0
- Support for unix sockets in reverse proxy mode
- Allow customizing public ports for Ironic and Inspector
…running without reverse proxy
Move hardys to emeritus_approvers
Werkzeug 2.2.0 broke behavior of sushy-tools until version 0.20.0 is out.
Pin Werkzeug to 2.1.2 until newer version of sushy-tools is out
This brings back full compatibility with latest versions of Werkzeug after changes in 2.2.0
Update sushy-tools to version 0.20.0
…single-inspector-if-on-noproxy-case/mohammed Add option to to listen on a single inspector interface
Since httpd, ironic and inspector share a volume, there is no point in allocating private ports and making their communication go through the network stack. Allow using unix sockets instead.
Support for unix sockets in reverse proxy mode
While 6385 and 5050 are reasonably established, an operator may choose to assign different ports (e.g. in case of a conflict). This change also makes it possible to have different listen and access ports for the rare case when there is another indirection between consumers and API (e.g. in case of OpenShift we want to have another reverse proxy on control plane nodes).
Allow customizing public ports for Ironic and Inspector
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@dtantsur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.