Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug OCPBUGS-3480: Improve resiliency of eTag handling #313

Merged

Conversation

rhjanders
Copy link

@rhjanders rhjanders commented Nov 9, 2022

This commit brings the upstream OpenStack/Sushy fixes improving eTag handling into OpenShift master branch:

https://review.opendev.org/c/openstack/sushy/+/862846

This commit brings the upstream OpenStack/Sushy fixes improving
eTag handling into OpenShift 4.13
@elfosardo
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@dtantsur
Copy link
Member

dtantsur commented Nov 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2022
@rhjanders rhjanders changed the title Improve resiliency of eTag handling OCPBUGS-3480: Improve resiliency of eTag handling Nov 10, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2022
@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-3480, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit brings the upstream OpenStack/Sushy fixes improving eTag handling into OpenShift master branch:

https://review.opendev.org/c/openstack/sushy/+/862846

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders rhjanders changed the title OCPBUGS-3480: Improve resiliency of eTag handling Bug OCPBUGS-3480: Improve resiliency of eTag handling Nov 10, 2022
@rhjanders
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-3480, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2022
@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-3480, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom November 10, 2022 10:55
@pamoedom
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 10, 2022
@rhjanders
Copy link
Author

Package tagged for production:
[janders@carbon sushy]$ ironic-builds tag production ocp-4.12 python-sushy-4.3.1-0.20221107165523.4ccbc97.el9
/usr/lib/python3.10/site-packages/koji/util.py:66: DeprecationWarning: krb_login is deprecated, use gssapi_login instead
warnings.warn(message, DeprecationWarning)
Validating sources...
Tagging builds...
Tagging python-sushy-4.3.1-0.20221107165523.4ccbc97.el9 in rhaos-4.12-ironic-rhel-9-candidate
Watching tasks (this may be safely interrupted)...
48916805 tagBuild (noarch): free
48916805 tagBuild (noarch): free -> closed
0 free 0 open 1 done 0 failed

48916805 tagBuild (noarch) completed successfully
Done!
[janders@carbon sushy]$

@iurygregory
Copy link

/test images

1 similar comment
@iurygregory
Copy link

/test images

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

@rhjanders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4c0a3e9 into openshift:master Nov 10, 2022
@openshift-ci-robot
Copy link

@rhjanders: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3480 has been moved to the MODIFIED state.

In response to this:

This commit brings the upstream OpenStack/Sushy fixes improving eTag handling into OpenShift master branch:

https://review.opendev.org/c/openstack/sushy/+/862846

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants