Pin ironic version

[elfosardo]

This should grant some control on what we're installing.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dtantsur]

I'm not sure how I feel about this.. It means that we need to bump the version every time a bug fix is released?

[openshift-ci-robot]

@elfosardo: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi	0820b04	link	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[elfosardo]

I'm not sure how I feel about this.. It means that we need to bump the version every time a bug fix is released?

every time a bug fix is released, we need to tag a different package anyway
this adds one more level of control directly on the image
I'm more worried about the integration between the different images to be honest, I did this PR to be able to run CI whenever we want to update a package, so update it in an explicit way instead of the silent cross-tag, but of course it has limitations.
Ideas welcome

[juliakreger]

I don't like it... but I see the plus side

If we specify the version, then the container build breaks hard if the mirror becomes invalid, or someone tries to make changes outside of the pipeline.

The downside is equally problematic. We have to manually touch each repo should there be a minor security issue in ironic instead of allowing it to get pulled in upon rebuild.

I guess I just have super mixed feelings on this.

[elfosardo]

this won't work as the repos are built using only the latest tagged package, so we incur in an issue where the build will start failing if we don't change the version, basically nullifying the reason of this PR