Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1866032: Configure ironic-conductor to auth to ironic-inspector #97

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Bug 1866032: Configure ironic-conductor to auth to ironic-inspector #97

merged 1 commit into from
Aug 7, 2020

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Aug 4, 2020

The ironic-conductor process needs to authenticate to the
ironic-inspector API, so we need to pass the auth config file options to
it also.

@zaneb
Configure ironic-conductor to auth to ironic-inspector
bb662a7 
The ironic-conductor process needs to authenticate to the
ironic-inspector API, so we need to pass the auth config file options to
it also.

This is somewhat complicated by the fact that by default, ironic-api
picks up both the ironic-dist.conf and ironic.conf files, so to maintain
behaviour when passing a list of config files explicitly we need to pass
both. (I have no idea where or how the default is configured.)

However, ironic-conductor does *not* use ironic-dist.conf by default,
and including it breaks CI. Therefore we pass ironic-dist.conf
explicitly to only ironic-api, and don't include it in the list that we
pass to both ironic-api and ironic-conductor.

(cherry picked from commit 174725f)
dhellmann
dhellmann approved these changes Aug 4, 2020
View reviewed changes
Copy link

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@zaneb
Copy link
Member Author

zaneb commented Aug 4, 2020

/cc @hardys

@zaneb
Copy link
Member Author

zaneb commented Aug 4, 2020

/retitle Bug 1866032: Configure ironic-conductor to auth to ironic-inspector

@openshift-ci-robot openshift-ci-robot changed the title [Bug 1866032] Configure ironic-conductor to auth to ironic-inspector Bug 1866032: Configure ironic-conductor to auth to ironic-inspector Aug 4, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2020
@openshift-ci-robot
Copy link

@zaneb: This pull request references Bugzilla bug 1866032, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1866032: Configure ironic-conductor to auth to ironic-inspector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member Author

zaneb commented Aug 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@zaneb: This pull request references Bugzilla bug 1866032, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2020
@hardys
Copy link

hardys commented Aug 5, 2020

/test e2e-metal-ipi

@zaneb
Copy link
Member Author

zaneb commented Aug 5, 2020

/retest

5 similar comments
@zaneb
Copy link
Member Author

zaneb commented Aug 5, 2020

/retest

@zaneb
Copy link
Member Author

zaneb commented Aug 5, 2020

/retest

@zaneb
Copy link
Member Author

zaneb commented Aug 5, 2020

/retest

@zaneb
Copy link
Member Author

zaneb commented Aug 6, 2020

/retest

@zaneb
Copy link
Member Author

zaneb commented Aug 6, 2020

/retest

@dhellmann
Copy link

/lgtm

Let's turn on the bot hammer for this one.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@zaneb zaneb mentioned this pull request Aug 7, 2020
Merged
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4cc869e into openshift:master Aug 7, 2020
@openshift-ci-robot
Copy link

@zaneb: All pull requests linked via external trackers have merged: openshift/ironic-image#97, metal3-io/ironic-image#186. Bugzilla bug 1866032 has been moved to the MODIFIED state.

In response to this:

Bug 1866032: Configure ironic-conductor to auth to ironic-inspector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano pushed a commit to andfasano/ironic-image that referenced this pull request Nov 18, 2020
@metal3-io-bot
Merge pull request openshift#97 from derekhiggins/no-log-files
e8b3724 
Stop logging to file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann approved these changes

@juliakreger juliakreger Awaiting requested review from juliakreger

@hardys hardys Awaiting requested review from hardys

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zaneb @openshift-ci-robot @hardys @dhellmann @openshift-bot @openshift-merge-robot