Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1241 #1344

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fixes #1241 #1344

merged 1 commit into from
Nov 17, 2021

Conversation

aiman-alsari
Copy link
Contributor

Rather than picking the first route then checking if it matches, select from all routes then grab the host of the matching one.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

Hi @aiman-alsari. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Contributor

akram commented Nov 16, 2021

/approve
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2021
@aiman-alsari
Fixes openshift#1241
43a85e8 
Rather than picking the first route then checking if it matches,
select from *all routes* then grab the host of the matching one.

If there are multiple matching routes for the Jenkins service, only then
should we pick the first one.
@aiman-alsari
Copy link
Contributor Author

/retest-required

@akram
Copy link
Contributor

akram commented Nov 16, 2021

Hi @aiman-alsari, thank you for your contribution. That looks ok to be merged; unless you wanted more tests?

@aiman-alsari
Copy link
Contributor Author

no, I'm good. Thanks @akram

@akram
Copy link
Contributor

akram commented Nov 17, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aiman-alsari, akram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3821b98 into openshift:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhelil jkhelil Awaiting requested review from jkhelil

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@akram akram

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiman-alsari @akram @openshift-merge-robot