Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-12627: Change kubectl prefix in help message #43

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

natifridman
Copy link
Contributor

Change kubectl prefix in help message to show the correct command for standalone

Change kubectl prefix in help message to show correct command for standalone
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 23, 2024

@natifridman: This pull request references CNF-12627 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Change kubectl prefix in help message to show the correct command for standalone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2024
Copy link

openshift-ci bot commented Jun 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@natifridman natifridman marked this pull request as ready for review June 24, 2024 07:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
Copy link

openshift-ci bot commented Jun 24, 2024

@natifridman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@natifridman
Copy link
Contributor Author

/cc @nocturnalastro @pixelsoccupied

@AlinaSecret
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
@AlinaSecret
Copy link
Contributor

@natifridman Thanks for the PR !!!! @

@pixelsoccupied
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3b21c5c into openshift:main Jun 25, 2024
3 checks passed
@natifridman natifridman deleted the help-prefix branch June 25, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants