Bug 2022281: Rebase v1.22.3 #1048
Conversation
Due to a cut-and-paste error in the original implementation in Kubernetes 1.19, support for generic ephemeral inline volumes in the PVC protection controller was incorrectly tied to the "storage object in use" feature gate.
Instead of a plain `Mutex`, use an `RWMutex` so that the common operations can proceed in parallel.
If a pod is killed (no longer wanted) and then a subsequent create/ add/update event is seen in the pod worker, assume that a pod UID was reused (as it could be in static pods) and have the next SyncKnownPods after the pod terminates remove the worker history so that the config loop can restart the static pod, as well as return to the caller the fact that this termination was not final. The housekeeping loop then reconciles the desired state of the Kubelet (pods in pod manager that are not in a terminal state, i.e. admitted pods) with the pod worker by resubmitting those pods. This adds a small amount of latency (2s) when a pod UID is reused and the pod is terminated and restarted.
…pick-of-#104847-upstream-release-1.22 Automated cherry pick of kubernetes#104847: kubelet: Handle UID reuse in pod worker
…ick-of-#104833-upstream-release-1.22 Automated cherry pick of kubernetes#104833 (1.22): Refine locking in API Priority and Fairness config controller
…k-of-#100125-upstream-release-1.22 Automated cherry pick of kubernetes#100125: 'New' Event namespace validate failed
v1.22: Fix test flake in old svc registry
…rry-pick-of-#104634-upstream-release-1.22 Automated cherry pick of kubernetes#104634: storege e2etest: Delete restored PVC/Pod in snapshottable
…ck-of-#104969-upstream-release-1.22 Automated cherry pick of kubernetes#104969: Propagate conversion errors
Otherwise, nodeNameToPodList[nodeName] list will have all its references identical (corresponding to the control variable reference). Thus, making all the pods in the list identical.
The issue on both tests is that before the refactor we had a method that was creating the `StorageClass` manifest only, this manifest was used later to be created by `TestBindingWaitForFirstConsumerMultiPVC`, after the refactor we're ensuring that the `StorageClass` exists as a resource before calling `TestBindingWaitForFirstConsumerMultiPVC` however this method is still attempting to create it, that's the reason behind the error: `resourceVersion should not be set on objects to be created This issue wasn't caught before because `TestBindingWaitForFirstConsumerMultiPVC` is creating the StorageClass without the common utility function, the solution is to remove the snippet that attempts to create the StorageClass againo
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
tjungblu
force-pushed
the
release-4.9
branch
from
a9a4b2f
to
9d60800
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
@tjungblu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-azure-upgrade |
|
/bugzilla refresh |
|
@tjungblu: This pull request references Bugzilla bug 2022281, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wangke19 could you please also take a look? |
There was a problem hiding this comment.
/lgtm
/approve
/label backports/validated-commits
/remove-label backports/unvalidated-commits
Manually overriding valid-bug since the first bump can't have a master BZ:
/remove-label bugzilla/invalid-bug
/label bugzilla/valid-bug
Manually overriding verify-commits since that will never pass on a k8s bump
/override ci/prow/verify-commits
openshift-ci
bot
added
backports/validated-commits
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@tjungblu: All pull requests linked via external trackers have merged: Bugzilla bug 2022281 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix contains the following changes coming from updated version of kubernetes up to v1.22.3:
Changelog for v1.22.3:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.22.md#v1223