[DO_NOT_MERGE] Test #1444
Closed
[DO_NOT_MERGE] Test #1444
+561,500
−715,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests print a v1.Pod with Sprintf, which includes the new field even when it is empty.
This adds a new resource.k8s.io API group with v1alpha1 as version. It contains four new types: resource.ResourceClaim, resource.ResourceClass, resource.ResourceClaimTemplate, and resource.PodScheduling.
This is needed for "kubectl get". It depends on the generated swagger docs.
This is the result of cd staging/src/k8s.io/api && UPDATE_COMPATIBILITY_FIXTURE_DATA=true go test ./...
This is in response to review feedback. Checking for valid node names and the set property catches programming mistakes in the components that have write permission.
It's new code, so we should follow the latest recommendations for logging.
This will be used for different individual packages. A separate repo is better than reusing something like component-helpers because dependencies will be different.
This is similar to the support code for generic ephemeral inline volumes. Differences: - to avoid stuttering, the functions are just resourceclaim.Name and resourceclaim.IsForPod - resourceclaim.Name returns the right name for both cases (template and reference), which will simplify some code Other helper functions check some simple status conditions.
The controller uses the exact same logic as the generic ephemeral inline volume controller, just for inline ResourceClaimTemplate -> ResourceClaim. In addition, it supports removal of pods from the ReservedFor field when those pods are known to not need the claim anymore. At the moment, only this special case is supported. Removal of arbitrary objects would imply granting full read access to all types to determine whether a) an object is gone and b) if the current incarnation is the one which is listed in ReservedFor. This may get added later.
Move events command to top level
update documentation after code freeze
…s-beta-enable-e2e-test Add e2e test for job pod failure policy used to match pod disruption
due to redesign where we changed from new endpoint to /apis. The expected error was not also changed. Caught by e2e tests when feature enabled. Should have been caught by unit test first but it was implemented without root /apis. Unit test also fixed
so that aggregated-apiservers can also take advantage. discovered by e2e tests with feature enabled
some subresources were not properly included in the array due to pointers becoming stale over a resize
add test for level based priorities
fix test flake in TestLegacyServiceAccountTokenTracking
…nit-test-flake Add logging for reconciler unit test
The https://k8s.io/docs/ website uses this marker to highlight that pages should not be directly edited in k/website
And keep OpenStack Cinder CSI translation
… for GC and Namespace controllers In general, setting the header will result in getting 429 when the server hasn't been ready. This prevents certain controllers like GC, Namespace from accidentally removing resources when the caches haven't been fully synchronized. OpenShift-Rebase-Source: 2ebf199
OpenShift-Rebase-Source: 2e5064e
In the tests, we oftentimes create pods directly by the administrative user and so their SCC-related privileges are being used to create the pods. The PSa label syncher however works by introspecting SAs in each namespace, and since the SAs in the direct pod creation use-cases don't have the SCC-related privileges, the labelsyncer evaluates these namespaces as "restricted" because only the "restricted-v2" SCC is ever assigned in the namespaces. This breaks tests where pods are created directly. OpenShift-Rebase-Source: 4b7ae56
…vice account token should be auto-generated OpenShift-Rebase-Source: a031438
OpenShift-Rebase-Source: 7bb1650
…eady OpenShift-Rebase-Source: fc3523f
…ugin The CSIInlineVolumeSecurity admission plugin inspects inline CSI volumes on pod creation and compares the security.openshift.io/csi-ephemeral-volume-profile label on the CSIDriver object to the pod security profile on the namespace. OpenShift-Rebase-Source: a65c34b
… changes that SCC will eventually make to the pod OpenShift-Rebase-Source: 6fe5c8f
OpenShift-Rebase-Source: 1ebcee1
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
backports/unvalidated-commits
|
/test k8s-e2e-gcp-ovn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test k8s-e2e-gcp-ovn |
|
/test k8s-e2e-gcp-ovn |
|
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.