WIP: k8s 1.29.0 #1791
Closed
WIP: k8s 1.29.0 #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controllers enabled by default should define feature gates in ControllerDescriptor.requiredFeatureGates and not during a descriptor registration in NewControllerDescriptors
…_watch_encoder Refactor streaming watch encoder to enable caching
[ut] increase covrage for kubelet/prober/results
[ut] Increase test coverage for kubelet/pleg
…ments Including JTI & node reference in issued service account tokens (kep 4193)
Promote APF API to v1
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
k8s.io/apiserver/storage/etcd: refactor etcd GetList.
…ion of the node e2e tests * It is observed in some of the periodic job results that the kubelet along with few other logs are not getting copied to the artifacts directory once the node e2e tests are executed * Following is the sample error log that is displayed once the tests are run ``` I1031 13:15:49.056897 40204 ssh.go:146] Running the command ssh, with args: [-o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /home/svanka/.ssh/google_compute_engine core@35.185.108.51 -- sudo ls core@35.185.108.51:/tmp/node-e2e-20231031T125637/results/*.log] E1031 13:16:15.346641 40204 ssh.go:149] failed to run SSH command: out: ls: cannot access 'core@35.185.108.51:/tmp/node-e2e-20231031T125637/results/*.log': No such file or directory , err: exit status 2 ``` * This change fixes the above issue and helps in gathering the required test artifacts once the tests execution is completed Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
golangci-lint: enable doc comment checking for cmd/kubeadm
[StructuredAuthorizationConfig] - CEL integration
Fix flaky test for services that shouldn't be available when PublishNotReadyAddresses is false
…forget-watcher cacher: when forgeting a watcher, call stopWatcherLocked multiple times
…mmand-for-scp-ing-all-files Single gcloud command for scp-ing all files
Fix panic when process RunScorePlugins for cap out of range
apiserver: set APF featuregate to stable
…iple times" This reverts commit bbca4a4.
In EnsureAdminClusterRoleBindingImpl() there are a couple of polls around CRB create calls. When testing the function a short retry and a timeout are used. These introduce around 2x20 fake client "connections" / poll iterations under a couple of test cases with 2 seconds overall test increase. Given the polls in EnsureAdminClusterRoleBindingImpl() are of type PollUntilContextTimeout() with "immediate" set to "true", the short retry / time out can be removed when testing, because one poll iteration is guaranteed and the tested function is at 100% coverage with reactors and test cases.
Signed-off-by: Monis Khan <mok@microsoft.com>
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
This commit renews openshift#327 What has changed compared to the original PR is: - The retryClient interface has been adapted to storage.Interface. - The isRetriableEtcdError method has been completely changed; it seems that previously the error we wanted to retry was not being retried. Even the unit tests were failing. Overall, I still think this is not the correct fix. The proper fix should be added to the etcd client. UPSTREAM: <carry>: retry etcd Unavailable errors This is the second commit for the retry logic. This commit adds unit tests and slightly improves the logging. During a rebase squash with the previous one.
When a PerformanceProfile configures a node for cpu partitioning, it also lets OVS use all the cpus available to burstable pods. To be able to do that, OVS was moved to its own slice and that slice needs to be re-added to cAdvisor for monitoring purposes.
…gnore file exists error Signed-off-by: Peter Hunt <pehunt@redhat.com>
Bump builder and base images to OCP 4.15 and RHEL 9 (where possible).
Revert: openshift#1310 Add support for ICSP and IDMS objects living at the same time. Signed-off-by: Qi Wang <qiwan@redhat.com>
Bump builder and base images to OCP 4.15 and RHEL 9 (where possible). This reverts 377868d, except the pause image bump to RHEL 9.
Signed-off-by: Harshal Patil <harpatil@redhat.com>
"head" sometimes exits before "rpmspec" finishes piping it all its data. Workaround that by separating the rpmspec and head calls.
Update REBASE.openshift.md file with new RHEL 9 images.
Remove "git rerere" suggestion. This has shown to be problematic in some cases.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
backports/unvalidated-commits
|
/test unit |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp |
1 similar comment
|
/test e2e-gcp |
|
/test e2e-gcp |
|
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This served its purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in kubernetes@c3eebb2