Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor HA profile to simplify damon #277

Merged
merged 1 commit into from
Mar 12, 2024
Merged

refactor HA profile to simplify damon #277

merged 1 commit into from
Mar 12, 2024

Conversation

aneeshkp
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@aneeshkp
refactor HA profile
b1f6237 
Signed-off-by: Aneesh Puttur <aputtur@redhat.com>
@aneeshkp aneeshkp changed the title refactor HA profile to simplity the method call refactor HA profile to simplify damon Mar 12, 2024
jzding
jzding approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
josephdrichard
josephdrichard approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@josephdrichard josephdrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, josephdrichard, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aneeshkp,josephdrichard,jzding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5f6347d into openshift:master Mar 12, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-linuxptp-daemon-container-v4.16.0-202403122214.p0.g5f6347d.assembly.stream.el9 for distgit linuxptp-daemon.
All builds following this will include this PR.

@jzding jzding mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephdrichard josephdrichard josephdrichard approved these changes

@jzding jzding jzding approved these changes

@pliurh pliurh Awaiting requested review from pliurh

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@jzding jzding

@josephdrichard josephdrichard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aneeshkp @openshift-bot @jzding @josephdrichard