Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy components into openshift-machine-api namespace #202

Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Feb 8, 2019

Create openshift-machine-api namespace
Deploy components into openshift-machine-api namespace
Once this get merged we can update the namespace of the machines run by the installer openshift/installer#1215

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@ingvagabund
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@ingvagabund
Copy link
Member

ingvagabund commented Feb 8, 2019

test/integration files needs to be updated as well:

$ grep -rn "openshift-cluster-api"
install/0000_30_machine-api-operator_00_namespace_cluster-api.yaml:4:  name: openshift-cluster-api
install/0000_30_machine-api-operator_00_namespace_cluster-api.yaml:6:    name: openshift-cluster-api
test/e2e/main.go:16:	namespace = "openshift-cluster-api"
test/integration/generate.sh:10:  namespace: openshift-cluster-api
test/integration/manifests/operator-deployment.yaml:5:  namespace: openshift-cluster-api
test/integration/manifests/ign-config.yaml:5:  namespace: openshift-cluster-api
test/integration/manifests/machineset.yaml:9:  namespace: openshift-cluster-api
test/integration/manifests/rbac.yaml:5:  name: default-account-openshift-cluster-api
test/integration/manifests/rbac.yaml:9:  namespace: openshift-cluster-api
test/integration/manifests/cluster.yaml:5:  namespace: openshift-cluster-api
test/integration/manifests/images.configmap.yaml:5:  namespace: openshift-cluster-api
test/integration/main.go:41:	targetNamespace          = "openshift-cluster-api"
pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go:23:	namespace = "openshift-cluster-api"

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2019
@enxebre
Copy link
Member Author

enxebre commented Feb 8, 2019

/test e2e-aws

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@spangenberg
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants