vSphere: Enter Failed phase on invalid configuration #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inconsistent use of wrapping means that in some cases the context of the original error is lost, as it is replaced by an entirely new error rather than just wrapped. Crucially, this meant that sometimes an error created with InvalidMachineConfiguration() was replaced instead of wrapped, meaning that the Machine controller would not see it and would not change the phase to Failed. This was inconsistent with the other machine API providers.
If the specified credentials do not exist, return an invalid configuration error. Code with the apparent intention of implementing this existed already, but didn't actually do anything.
|
@zaneb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alexander-demicev
approved these changes
Oct 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the enhancement proposal, Machine API providers should put the Machine into the
Failedphase if the configuration is invalid. This was not working for the vSphere provider, due to the correct error being dropped in the error handling chain. This change ensures that the vSphere provider will behave consistently with the other providers in the event of invalid configuration.