-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere: Enter Failed phase on invalid configuration #735
vSphere: Enter Failed phase on invalid configuration #735
Conversation
Inconsistent use of wrapping means that in some cases the context of the original error is lost, as it is replaced by an entirely new error rather than just wrapped. Crucially, this meant that sometimes an error created with InvalidMachineConfiguration() was replaced instead of wrapped, meaning that the Machine controller would not see it and would not change the phase to Failed. This was inconsistent with the other machine API providers.
If the specified credentials do not exist, return an invalid configuration error. Code with the apparent intention of implementing this existed already, but didn't actually do anything.
@zaneb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demichev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
According to the enhancement proposal, Machine API providers should put the Machine into the
Failed
phase if the configuration is invalid. This was not working for the vSphere provider, due to the correct error being dropped in the error handling chain. This change ensures that the vSphere provider will behave consistently with the other providers in the event of invalid configuration.