OCPBUGS-36185: IBMCloud: Handle pagination for subnets #41
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@cjschaef: This pull request references Jira Issue OCPBUGS-36185, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
pkg/actuators/client/client.go
Outdated
| subnetList, _, err := c.vpcService.ListSubnets(subnetOption) | ||
| subnetPager, err := c.vpcService.NewSubnetsPager(subnetOption) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
Should the error be wrapped with additional context?
| return "", err | |
| return "", fmt.Errorf("could not get subnet pager: %w", err) |
There was a problem hiding this comment.
Yep, I can wrap the error....
Add pagination support for subnet lookups. Related: https://issues.redhat.com/browse/OCPBUGS-36185
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@cjschaef: Jira Issue OCPBUGS-36185: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36185 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.17.0-202407041312.p0.gc2ea2b4.assembly.stream.el9 for distgit ose-ibmcloud-machine-controllers. |
|
/cherry-pick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12 |
|
@cjschaef: new pull request created: #42 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add pagination support for subnet lookups.
Related: https://issues.redhat.com/browse/OCPBUGS-36185