e2e/testing: A few small patches #361
Conversation
openshift-ci-robot
added
size/S
|
No new features, simply a docs change, typo fix, and CI debugging aid. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| // This includes generating new desiredMachineConfig and update of machines. | ||
| // If true, changes to this machine pool should be stopped, | ||
| // including generating new desiredMachineConfig and update of machines. | ||
| // This flag is intended for administrators to change. |
There was a problem hiding this comment.
wait, IMO all the fields in spec are for edit. not just this...
There was a problem hiding this comment.
Hm...I thought I saw something else in the operator changing the spec, but trying now I can't find anything.
Dropped that patch out and updated ⬇️
|
/lgtm cancel |
To aid debugging. Still need to change prow to use this.
cgwalters
force-pushed
the
misc-osupdate-prep
branch
from
e0c35f1
to
5bbe956
Compare
|
/retest |
|
@cgwalters could we put something about testing/e2e/etc in the PR title so it's easier to find in github list later? |
ashcrow did that, ok now? |
|
@cgwalters great! 👍 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…penshift-4.8-ose-cluster-samples-operator Updating ose-cluster-samples-operator builder & base images to be consistent with ART
No description provided.