New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon/update: Log each error before retrying #412

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
7 participants
@jlebon
Copy link
Member

jlebon commented Feb 12, 2019

That way, we get more feedback when retrying since it can take a while.
And we also catch the instance when e.g. different errors might have
happened each time.

@cgwalters

This comment has been minimized.

Copy link
Contributor

cgwalters commented Feb 12, 2019

/lgtm

But...I think the real fix here is something like #410 where all of the fiddly details of "retry in a loop" are codified and consistent.

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 12, 2019

could you also fix the formatting some lines below:

			return errors.Wrapf(lastErr, "Failed to drain node (%s tries)", backoff.Steps)

it should be %d as backoff.Steps is an int, not a string

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 12, 2019

/hold

Per @runcom's comment.

@ashcrow
Copy link
Member

ashcrow left a comment

Looks good as is, but there was a request for update.

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 12, 2019

Looks good as is, but there was a request for update.

a really nit(y) one lol sorry for that

daemon/update: Log each error before retrying
That way, we get more feedback when retrying since it can take a while.
And we also catch the instance when e.g. different errors might have
happened each time.

@jlebon jlebon force-pushed the jlebon:pr/add-drain-logging branch from efe87d4 to 12d5f26 Feb 12, 2019

@jlebon

This comment has been minimized.

Copy link
Member Author

jlebon commented Feb 12, 2019

it should be %d as backoff.Steps is an int, not a string

Fixed!

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 12, 2019

/lgtm

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 12, 2019

/hold cancel

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 12, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, jlebon, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,jlebon,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 12, 2019

/retest

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 691bf5f into openshift:master Feb 12, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rhel-images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment