Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2102673: fix frr start race condition #69

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

fedepaol
Copy link
Member

@fedepaol fedepaol commented Jul 4, 2022

Making the interaction with FRR more robust introducing retries after failures in both the call of the reloader (if the pid is not there yet) and if we find that the interaction between the reloader and the container fails.

If the reload fails, most likely due to the reloader container not ready
yet, we wait and try to reload the configuration again.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
If we detect a failure in the configuration processing, we ask the
debouncer to retry using the latest configuration.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
@fedepaol fedepaol requested a review from russellb as a code owner July 4, 2022 20:09
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2022

@fedepaol: This pull request references Bugzilla bug 2102673, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @asood-rh

In response to this:

Bug 2102673: fix frr start race condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from asood-rh, dcbw and dougbtv July 4, 2022 20:09
@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@fedepaol
Copy link
Member Author

fedepaol commented Jul 4, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jul 4, 2022

@fedepaol: This pull request references Bugzilla bug 2102673, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @asood-rh

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oribon
Copy link

oribon commented Jul 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD bc35745 and 8 for PR HEAD eedfad4 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

@fedepaol: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit b751a94 into openshift:main Jul 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 5, 2022

@fedepaol: All pull requests linked via external trackers have merged:

Bugzilla bug 2102673 has been moved to the MODIFIED state.

In response to this:

Bug 2102673: fix frr start race condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

fedepaol commented Aug 5, 2022

/cherry-pickr release 4.11

@fedepaol
Copy link
Member Author

fedepaol commented Aug 5, 2022

/cherry-pick release-4.11

@openshift-cherrypick-robot

@fedepaol: new pull request created: #80

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants