-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-1745: testing instructions for disconnected operation #2443
USHIFT-1745: testing instructions for disconnected operation #2443
Conversation
@dhellmann: This pull request references USHIFT-1745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ggiguash |
@dhellmann: This pull request references USHIFT-1745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/user/howto_test_offline.md
Outdated
6. Add a fake IP on the loopback interface. | ||
|
||
``` | ||
nmcli con add type loopback con-name stable-microshift ifname lo ip4 10.44.0.1/32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think loopback-microshift
would better depict the purpose of this interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggiguash This PR is just to record the manual testing instructions that were actually used in a public place. I don't actually expect anyone to follow these steps exactly as written. I expect a user will configure their system with the end-result of these commands, using either a kickstart or a blueprint. We will cover that approach in the product docs.
5f391b4
to
70739c9
Compare
@ggiguash I've address the comments and this is ready for another review. |
70739c9
to
c7c4ec3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dhellmann: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.