Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-1745: testing instructions for disconnected operation #2443

Merged

Conversation

dhellmann
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@dhellmann: This pull request references USHIFT-1745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor Author

/assign @ggiguash

@openshift-ci openshift-ci bot requested review from jogeo and pmtk October 5, 2023 14:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2023

@dhellmann: This pull request references USHIFT-1745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

6. Add a fake IP on the loopback interface.

```
nmcli con add type loopback con-name stable-microshift ifname lo ip4 10.44.0.1/32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think loopback-microshift would better depict the purpose of this interface?

docs/user/howto_test_offline.md Show resolved Hide resolved
docs/user/howto_test_offline.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggiguash This PR is just to record the manual testing instructions that were actually used in a public place. I don't actually expect anyone to follow these steps exactly as written. I expect a user will configure their system with the end-result of these commands, using either a kickstart or a blueprint. We will cover that approach in the product docs.

docs/user/howto_test_offline.md Show resolved Hide resolved
docs/user/howto_test_offline.md Show resolved Hide resolved
docs/user/howto_test_offline.md Show resolved Hide resolved
@dhellmann dhellmann force-pushed the USHIFT-1745-user-docs-disconnected branch from 5f391b4 to 70739c9 Compare October 10, 2023 12:01
@dhellmann
Copy link
Contributor Author

@ggiguash I've address the comments and this is ready for another review.

@dhellmann dhellmann force-pushed the USHIFT-1745-user-docs-disconnected branch from 70739c9 to c7c4ec3 Compare October 10, 2023 12:03
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 5d0d5d0 into openshift:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants