CI: Split up E2E test's runBackupAndRestore in preparation for virtualization tests. #1345
Conversation
openshift-ci
bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test 4.12-e2e-test-aws |
|
/override ci/prow/4.12-e2e-test-aws these are flakes |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.12-e2e-test-aws, ci/prow/4.14-e2e-test-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test 4.14-e2e-test-aws |
openshift-merge-robot
added
the
needs-rebase
Move application-specific fields into application-specific struct, and keep a base struct for fields common to virtualization tests. Signed-off-by: Matthew Arnold <marnold@redhat.com>
Turn runBackupAndRestore into separate prepare, backup, and restore steps in preparation for virtualization testing. VM tests need a few extra steps but otherwise work pretty much the same as the existing application tests, so this split should reduce duplication. Signed-off-by: Matthew Arnold <marnold@redhat.com>
mrnold
force-pushed
the
ci-prepare-virt-backup
branch
from
0e974f8
to
6605639
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
Signed-off-by: Matthew Arnold <marnold@redhat.com>
|
/test 4.14-e2e-test-kubevirt-aws |
|
/retest |
|
/test 4.14-e2e-test-azure |
|
/test 4.13-e2e-test-aws |
|
/test 4.12-e2e-test-aws |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43, mpryc, mrnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mrnold remember we can override if needed https://github.com/openshift/oadp-operator/blob/master/OWNERS |
|
/override ci/prow/4.12-e2e-test-aws |
|
@mateusoliveira43: Overrode contexts on behalf of mateusoliveira43: ci/prow/4.12-e2e-test-aws, ci/prow/4.13-e2e-test-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mrnold: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…lization tests. (openshift#1345) * Split up BackupRestoreCase type. Move application-specific fields into application-specific struct, and keep a base struct for fields common to virtualization tests. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Split up runBackupAndRestore. Turn runBackupAndRestore into separate prepare, backup, and restore steps in preparation for virtualization testing. VM tests need a few extra steps but otherwise work pretty much the same as the existing application tests, so this split should reduce duplication. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Clean up "v1 is redundant" lint failures. Signed-off-by: Matthew Arnold <marnold@redhat.com> --------- Signed-off-by: Matthew Arnold <marnold@redhat.com>
Extract the common code factoring from #1333 to its own pull request. This should not create any functional change, but it should make it much easier to review a new VM testing pull request.