Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Run() calls to oc #82

Closed
afflom opened this issue Sep 13, 2021 · 4 comments
Closed

Remove Run() calls to oc #82

afflom opened this issue Sep 13, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@afflom
Copy link
Contributor

afflom commented Sep 13, 2021

bundle inherits a lot of logic from oc for handling releases and operators. It also uses the registry client from oc mirror for general container image mirroring. The most of the pieces that we needed from oc were unexported, so we resorted to calling Run() from each applicable oc package. By using the Run function from the oc imports, we lose control over logging output, stdout/err, and any other behavior that we want to program into the process.

Remove the Run() calls to oc imports and either use internal logic for or PR oc to export the needed pieces for reuse here.

@afflom afflom added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 13, 2021
@afflom afflom modified the milestone: Alpha2 Sep 13, 2021
@afflom afflom added this to the Backlog milestone Nov 30, 2021
@jpower432 jpower432 removed this from the Backlog milestone Feb 1, 2022
@jpower432 jpower432 added this to the Release-4.11 milestone Feb 7, 2022
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2022
@jpower432
Copy link
Contributor

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 19, 2022
@lmzuccarelli
Copy link
Contributor

/close

@openshift-ci openshift-ci bot closed this as completed Apr 23, 2024
Copy link

openshift-ci bot commented Apr 23, 2024

@lmzuccarelli: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants