Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2093046: oc debug: Add priorityClassName into node debugging pod template #1263

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Bug 2093046: oc debug: Add priorityClassName into node debugging pod template #1263

merged 1 commit into from
Oct 24, 2022

Conversation

ardaguclu
Copy link
Member

When user tries to debug a pod, priorityClassName is automatically copied to this debug pod. However, there is no such information for node debugging.

This PR adds "openshift-user-critical" priorityClassName into node debugging pod which means that "it is fine node debugging pod to be preempted by user-workload and OOMKilled."[1]

[1] https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes

@ardaguclu
oc debug: Add priorityClassName into node debugging pod template
adce0a8 
When user tries to debug a pod, priorityClassName is automatically
copied to this debug pod. However, there is no such information
for node debugging.

This PR adds "openshift-user-critical" priorityClassName into
node debugging pod which means that "it is fine node debugging pod
to be preempted by user-workload and OOMKilled."
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

@ardaguclu: This pull request references Bugzilla bug 2093046, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Bug 2093046: oc debug: Add priorityClassName into node debugging pod template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

cc: @stbenjam

soltysh
soltysh approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d506580 and 2 for PR HEAD adce0a8 in total

@ardaguclu
Copy link
Member Author

/retest-required

ardaguclu added a commit to ardaguclu/origin that referenced this pull request Oct 18, 2022
@ardaguclu
Remove must-gather pod from lack priorityclass exception list
6425d57 
must-gather pod was added exception list because `oc debug node`
does not include priorityClassName. After this PR adds
openshift/oc/pull/1263 priorityClassName statically, we can remove must-gather
pod from priorityclass exception list.
@ardaguclu ardaguclu mentioned this pull request Oct 18, 2022
Merged
@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4d1423f and 1 for PR HEAD adce0a8 in total

@ardaguclu
Copy link
Member Author

/retest-required

5 similar comments
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7d35a86 into openshift:master Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@ardaguclu: All pull requests linked via external trackers have merged:

Bugzilla bug 2093046 has been moved to the MODIFIED state.

In response to this:

Bug 2093046: oc debug: Add priorityClassName into node debugging pod template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the bug-2093046 branch October 24, 2022 18:38
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
@ardaguclu @tjungblu
Remove must-gather pod from lack priorityclass exception list
7fb586f 
must-gather pod was added exception list because `oc debug node`
does not include priorityClassName. After this PR adds
openshift/oc/pull/1263 priorityClassName statically, we can remove must-gather
pod from priorityclass exception list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ardaguclu @openshift-ci-robot @soltysh @openshift-merge-robot