Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] OCPBUGS-33917: add alert data to upgrade health in oc adm upgrade status #1771

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1740

/assign petr-muller

this commit adds alerts that fire during the upgrade to
`upgrade health` section.

by default all the alerts that started firing after intiating the
upgrade will appear in the upgrade health section

we also have allowed alerts that will show alerts that firing before
the upgrade was started.

We've not added examples for alerts and are just testing it with
unit tests. This is to reduce the input data in the examples.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33896 has been cloned as Jira Issue OCPBUGS-33917. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-33917: add alert data to upgrade health in oc adm upgrade status

In response to this:

This is an automated cherry-pick of #1740

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-33896: add alert data to upgrade health in oc adm upgrade status [release-4.16] OCPBUGS-33917: add alert data to upgrade health in oc adm upgrade status May 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 18, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33917, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1740

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 18, 2024 21:23
@petr-muller
Copy link
Member

/test ci/prow/e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@petr-muller: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-rpms-from-tar
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-builds
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test images
  • /test rpm-build
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-certrotation
  • /test e2e-metal-ipi-ovn-ipv6
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-oc-release-4.16-build-rpms-from-tar
  • pull-ci-openshift-oc-release-4.16-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-oc-release-4.16-e2e-aws-ovn
  • pull-ci-openshift-oc-release-4.16-e2e-aws-ovn-serial
  • pull-ci-openshift-oc-release-4.16-e2e-aws-ovn-upgrade
  • pull-ci-openshift-oc-release-4.16-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-oc-release-4.16-images
  • pull-ci-openshift-oc-release-4.16-rpm-build
  • pull-ci-openshift-oc-release-4.16-security
  • pull-ci-openshift-oc-release-4.16-unit
  • pull-ci-openshift-oc-release-4.16-verify
  • pull-ci-openshift-oc-release-4.16-verify-deps

In response to this:

/test ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@petr-muller
Copy link
Member

/test e2e-aws-ovn-serial

@petr-muller
Copy link
Member

/test e2e-agnostic-ovn-cmd
/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 20, 2024
@openshift-ci-robot
Copy link

@petr-muller: This pull request references Jira Issue OCPBUGS-33917, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-33896 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-33896 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @shellyyang1989

In response to this:

/test e2e-agnostic-ovn-cmd
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

/approve
/lgtm
/hold

This needs to wait for QE testing in 4.17

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@petr-muller
Copy link
Member

Superseded by #1794

/cloes

@petr-muller
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this Jun 3, 2024
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

@petr-muller: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33917. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1740

/assign petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants