Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential fix for openshift/oc/issues/1814. #1817

Closed
wants to merge 1 commit into from
Closed

Potential fix for openshift/oc/issues/1814. #1817

wants to merge 1 commit into from

Conversation

germanparente
Copy link

oc adm groups sync is comparing dn's / basedn's case sensitive when it should not be in ldap.

@germanparente
Potential fix for openshift/issues/1814: group sync is showing error:…
3ec1dc1 
…'entry would search outside of the base dn specified
@openshift-ci openshift-ci bot requested review from ardaguclu and deads2k July 5, 2024 13:40
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ardaguclu
ardaguclu reviewed Jul 5, 2024
View reviewed changes
vendor/github.com/openshift/library-go/pkg/security/ldapquery/query.go
if !baseDN.AncestorOf(dn) && !baseDN.Equal(dn) {
return nil, NewQueryOutOfBoundsError(attributeValue, o.BaseDN)
}
if !baseDN.AncestorOfFold(dn) && !baseDN.EqualFold(dn) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't directly modify the files under the vendor directory.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@germanparente: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps 3ec1dc1 link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@germanparente
Copy link
Author

Apologies for the noise. I will close this and do my PR in https://github.com/openshift/library-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu ardaguclu left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germanparente @ardaguclu