Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTA-1292: upgrade-status: improve messages for NotReady/DiskPressure/NetworkUnavailable #1851

Merged
merged 1 commit into from
Sep 16, 2024
Merged

OTA-1292: upgrade-status: improve messages for NotReady/DiskPressure/NetworkUnavailable #1851

merged 1 commit into from
Sep 16, 2024

Conversation

hongkailiu
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2024 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1292 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/OTA-1292

Addressing the 4th case from #1838 (review)

/cc @petr-muller @Davoska

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2024
petr-muller
petr-muller reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the PR is marked wip but I thought I'd give some feedback, less about the code but perhaps on the functionality

...rade/status/examples/4.16.0-ec2-control-plane-updated-pdb-prohibits-draining.detailed-output Outdated Show resolved Hide resolved
pkg/cli/admin/upgrade/status/mco/layered_node_state.go Outdated Show resolved Hide resolved
...admin/upgrade/status/examples/4.16.0-ec2-control-plane-updated-pdb-prohibits-draining.output Outdated Show resolved Hide resolved
pkg/cli/admin/upgrade/status/mco/layered_node_state.go Outdated Show resolved Hide resolved
pkg/cli/admin/upgrade/status/mco/layered_node_state.go Outdated Show resolved Hide resolved
pkg/cli/admin/upgrade/status/workerpool.go Outdated Show resolved Hide resolved
@hongkailiu
Copy link
Member Author

I will follow up tomorrow.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2024
@hongkailiu hongkailiu changed the title [wip]OTA-1292: upgrade-status: improve messages for NotReady/DiskPressure/NetworkUnavailable OTA-1292: upgrade-status: improve messages for NotReady/DiskPressure/NetworkUnavailable Aug 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
petr-muller
petr-muller reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good! I feel like we're changing the logic fairly significantly but we don't have many tests to exercise the new behavior, so I would feel safer if we had some basic testcases for the improved logic: given a node in a certain state, what is the expected status we report, and what are the insights we report (as unit tests, not the example ones, although having one example showing multiple conditions like not ready && disk pressure would not hurt)

We don't need 100% code coverage for all possible cases ofc, but reasonable coverage of the main branches (unschedulable node, node with a bad condition but below the duraiton threshold, node with multiple bad conditions sound like the basic cases?).

pkg/cli/admin/upgrade/status/workerpool_test.go Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 4b21025 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

petr-muller
petr-muller approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work!

/lgtm
/hold

Holding to give QE chance to test this before merging (writing brief testing instructions may be handy for them to help verifying the new behavior)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2024
@evakhoni
Copy link

follow up the discussion in the ticket, considering this one pre-merge verified
/label qe-approved
/unhold

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1292 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/OTA-1292

Addressing the 4th case from #1838 (review)

/cc @petr-muller @Davoska

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@petr-muller
Copy link
Member

:shipit:

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e3584b9 and 2 for PR HEAD 4b21025 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 4682bd8 into openshift:master Sep 16, 2024
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-cli
This PR has been included in build openshift-enterprise-cli-container-v4.18.0-202409162307.p0.g4682bd8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-tools
This PR has been included in build ose-tools-container-v4.18.0-202409162307.p0.g4682bd8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-deployer
This PR has been included in build openshift-enterprise-deployer-container-v4.18.0-202409162307.p0.g4682bd8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cli-artifacts
This PR has been included in build ose-cli-artifacts-container-v4.18.0-202409162307.p0.g4682bd8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hongkailiu @openshift-ci-robot @evakhoni @petr-muller @openshift-bot @openshift-merge-robot