Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filtering for service binding services #5015

Merged

Conversation

mohammedzee1000
Copy link
Contributor

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR hides service binding services from being listed as it is not a service that a user can use

Which issue(s) this PR fixes:

Fixes #4861

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

> odo create nodejs
> odo service create etcdoperator.v0.9.4-clusterwide/EtcdCluster
# w/o the change
> odo service list
NAME                                            MANAGED BY ODO     STATE          AGE
EtcdCluster/etcdcluster                         Yes (java)         Pushed         21m48s
ServiceBinding/java-etcdcluster-etcdcluster     Yes (java)         Not pushed   
# with the change
> odo service list
NAME                        MANAGED BY ODO     STATE      AGE
EtcdCluster/etcdcluster     Yes (java)         Pushed     22m46s

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. labels Aug 23, 2021
@netlify
Copy link

netlify bot commented Aug 23, 2021

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: 7398ef9

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6123734df26a2d00077f3811

😎 Browse the preview: https://deploy-preview-5015--odo-docusaurus-preview.netlify.app

@mohammedzee1000
Copy link
Contributor Author

json active project error
/retest

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mohammedzee1000 mohammedzee1000 changed the title WIP Adding filtering for service binding services Adding filtering for service binding services Aug 25, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 25, 2021
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

(small change)

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Aug 25, 2021
@mohammedzee1000
Copy link
Contributor Author

project in json error
/retest

@mohammedzee1000
Copy link
Contributor Author

/refresh

@openshift-ci-robot
Copy link
Collaborator

@mohammedzee1000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v4.8-integration-e2e eaa4d6d link /test v4.8-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mohammedzee1000
Copy link
Contributor Author

/test v4.8-integration-e2e

@openshift-merge-robot openshift-merge-robot merged commit 117e6b4 into redhat-developer:main Aug 26, 2021
@kadel kadel mentioned this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hide ServiceBinding from odo service list
4 participants