-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.7] Allow for firewalld on atomic host #6762
[3.7] Allow for firewalld on atomic host #6762
Conversation
backports #6763 |
29c67f8
to
65b16d2
Compare
@sdodson I figure this is as good a place as any to work through this. I applied your patch and the next issue I see is an error related to trying to install firewalld, which isn't required on atomic host:
|
a605a4e
to
02d1a0a
Compare
02d1a0a
to
4738c6d
Compare
Right now this is only available on fedora so guard it with openshift_enable_unsupported_configurations
4738c6d
to
359e643
Compare
that should be fixed now |
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign vrutkovs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Right now this is only available on fedora so guard it with
openshift_enable_unsupported_configurations