Add Interface to make sync more unit-testable #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
/lint |
There was a problem hiding this comment.
@Kargakis: 1 warning.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
pkg/addons/client.go
Outdated
| kaggregator "k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset" | ||
| ) | ||
|
|
||
| type Interface interface { |
There was a problem hiding this comment.
Golint comments: exported type Interface should have comment or be unexported. More info.
0xmichalis
changed the title
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
Closed
openshift-ci-robot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@openshift/sig-azure this is a step towards making the sync plugin more unit-testable.