Add Initial KNI and KubeVirt documentation structure, VM List design #159
Conversation
This update includes the basic KNI and KubeVirt structure for documenting designs along with an initial proposal for the VM List view in KubeVirt has been installed. The admin will see a list of Virtual Machines under Workloads and will be able to do typical filtering of that list.
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @lizsurette. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
|
@beanh66 I added you as a reviewer - but let me know what the typical process is for getting a PR reviewed... Maybe I should tag @openshift/team-ux-review ? :) |
There was a problem hiding this comment.
Thanks for adding @lizsurette. The organization looks great. I left some comments regarding the VM lists.
|
|
||
|  | ||
|
|
||
| Statuses other than Running or Off should be colored blue to indicate that they can be hovered and/or clicked. |
There was a problem hiding this comment.
This is not consistent with OpenShift today. Definitely a cool idea, but I think we would want to change our status pattern across the board and not only for VMs! We should consider that change in a separate PR.
| - If possible, a tooltip should appear on hover with the exact creation date, including year. | ||
| - Node | ||
| - IP Address | ||
| - FQDN |
There was a problem hiding this comment.
This table looks very cramped for space. 6 columns seems to be the max number we will display in list views. Is there something you can drop? Also wondering if this is in priority order because responsive states will drop columns from right to left.
| - Namespace | ||
| - Status | ||
| - Running, Off, Error (with custom messages), Cloning, Migrating, Importing, Warning, Pending (with changes that will apply after restart), Unknown | ||
| - Created |
There was a problem hiding this comment.
I may recommend dropping created unless there's a specific reason it is needed for VMs. We only show created for Secrets and Config Maps. If it needs to stay, can you update the format to match that of secrets and config maps?
|
|
||
|  | ||
|
|
||
| When a VM is running the Run option is replaced with two dropdowns for Power and Connect to Console. |
There was a problem hiding this comment.
We don't do anything like this today but I can see the need for sure. We may want to run by Sam. Curious what other OpenShift designers think!
|
@lizsurette @beanh66 i thought we were tagging @openshift/team-ux-leads ? |
That's fine with me! The designers on KNI and Kubevirt can tag whichever group(s) or people needed, so just let me know if 'team-ux-leads' is enough or if we want a broader audience as these PRs come in. |
|
That works @serenamarie125 @lizsurette 👍 |
This update includes the basic KNI and KubeVirt structure for documenting designs along with an initial proposal for the VM List view in KubeVirt has been installed. The admin will see a list of Virtual Machines under Workloads and will be able to do typical filtering of that list.