Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-1390: Update kubernetes metadata plugin to allow kubeapi mocking #2190

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • Updates the fluentd-kubernetes_metadata_plugin to v2.7.1 to allow mocking of the kube api calls for testing

/hold

Links

https://issues.redhat.com/browse/LOG-1390

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@vimalk78
Copy link
Contributor

/lgtm

1 similar comment
@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vimalk78, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov
Copy link
Contributor

/retest

3 similar comments
@jcantrill
Copy link
Contributor Author

/retest

@droslean
Copy link
Member

/retest

@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/test smoke-5-2

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcantrill
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 69b95a8 into openshift:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants