Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-1927: Remove devel packages from final image (e.g gcc) #2208

Merged
merged 1 commit into from
Nov 23, 2021
Merged

LOG-1927: Remove devel packages from final image (e.g gcc) #2208

merged 1 commit into from
Nov 23, 2021

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • Removes devel packages from fluent image (e.g. gcc, nodejs)

cc @syedriko The Dockerfile.in will need to be copied to midstream files once this merges
cc @vimalk78

Links

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

blocked by openshift/release#23809

@jcantrill
Copy link
Contributor Author

/retest

1 similar comment
@jcantrill
Copy link
Contributor Author

/retest

alanconway
alanconway reviewed Nov 22, 2021
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit adf1062 into openshift:master Nov 23, 2021
@jcantrill jcantrill deleted the log1927 branch November 29, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway alanconway left review comments

@shwetaap shwetaap Awaiting requested review from shwetaap

Assignees

@alanconway alanconway

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcantrill @openshift-bot @alanconway @openshift-merge-robot