Allow editing service instances again if previous update failed #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/bug
|
We might change the edit dialog to re-enable the back button on a failed update, but I think that change is probably too big for 3.7. |
|
/hold I have a bug |
openshift-ci-robot
added
the
do-not-merge/hold
Service catalog now allows users to edit a service instance if the previous update failed. We were incorrectly blocking it in the UI since we check for readiness instead of failure.
spadgett
force-pushed
the
edit-not-ready
branch
from
850ca9b
to
9c9c926
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
jwforres
approved these changes
Nov 7, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service catalog now allows users to edit a service instance if the previous
update failed. We were incorrectly blocking it in the UI since we check for
readiness instead of failure.
/kind bug
/assign @jwforres @jeff-phillips-18