[1.4] Fix image pruning with both strong & weak refs

[soltysh]

Fix a logic error where an image could incorrectly be considered
prunable if there were both strong and weak references from an image
stream to the image.

1.4 cherrypick of #13671

[pweil-]

LGTM - merging on green

[pweil-]

[test]

[pweil-]

re[test]

[pweil-]

flake #12007 re[test]

[pweil-]

[test]

[eparis]

[merge] just to get it in the queue somewhere?

[openshift-bot]

Evaluated for origin merge up to aa1043c

[openshift-bot]

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/281/) (Base Commit: 977f53a)

[pweil-]

#13271
[test]

[openshift-bot]

Evaluated for origin test up to aa1043c

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/655/) (Base Commit: 977f53a)

[pweil-]

Seems to be having issues with:

++ export PATH
+ os::build::rpm::get_nvra_vars
bash: line 5: os::build::rpm::get_nvra_vars: command not found
++ os::util::trap::err_handler
++ local -r return_code=127
++ local -r last_command=os::build::rpm::get_nvra_vars

@mfojtik the only place I can find that is: b95268c#diff-c678ee0710aaec9235e19633904cef51 and doesn't exist in the 1.4 branch. Ideas?

In any case the test_pull_request_origin_integration, test_pull_request_origin_check, and test_pull_request_origin_extended_networking_minimal passed..

[stevekuznetsov]

Historically we have never versioned the jobs that run our CI. As of late there has been more churn than usual on the support code and 1.4 branch is ~150 commits behind 1.5 ... unclear if the backport is a reasonable thing to do or not, but these errors are expected.

[stevekuznetsov]

If you want to run conformance tests without the Ansible installation, use https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_extended_conformance/ manually.