Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. #14495

Conversation

aveshagarwal
Copy link
Contributor

@aveshagarwal aveshagarwal commented Jun 6, 2017

@derekwaynecarr

As the upstream PR kubernetes/kubernetes#47003 is merged now, I have updated this PR.

@aveshagarwal aveshagarwal force-pushed the master-scheduler-aggregate-errors-issue branch from 0d873f0 to bc29c05 Compare June 6, 2017 15:47
@aveshagarwal aveshagarwal changed the title UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. [DO -NOT-MERGE] UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. Jun 7, 2017
@aveshagarwal
Copy link
Contributor Author

Do not merge yet as discussions are still going on in upstream kube PR.

@aveshagarwal aveshagarwal force-pushed the master-scheduler-aggregate-errors-issue branch from bc29c05 to 855d721 Compare June 8, 2017 14:54
@aveshagarwal aveshagarwal changed the title [DO -NOT-MERGE] UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. Jun 8, 2017
@derekwaynecarr
Copy link
Member

[merge][severity:blocker]

@smarterclayton
Copy link
Contributor

# github.com/openshift/origin/vendor/k8s.io/apimachinery/pkg/util/errors
vendor/k8s.io/apimachinery/pkg/util/errors/errors_test.go:289: undefined: sort.Slice
vendor/k8s.io/apimachinery/pkg/util/errors/errors_test.go:293: undefined: sort.Slice

@aveshagarwal
Copy link
Contributor Author

@smarterclayton looking.

…t. Helps

Helps with some scheduler errors that fill the log enormously.
@aveshagarwal
Copy link
Contributor Author

Its happening because golang-1.7 does not understand sort.Slice whereas golang 1.8 does. Would it be ok to remove the unit test part and just have the main code?

@derekwaynecarr
Copy link
Member

hmm, can we write go 1.7 style sort? would make any other future backport requests not awful.

@aveshagarwal aveshagarwal force-pushed the master-scheduler-aggregate-errors-issue branch from 855d721 to 77a6bb2 Compare June 15, 2017 19:37
@aveshagarwal
Copy link
Contributor Author

@derekwaynecarr I have updated this PR to make sorting work with go 1.7. I have put same upstream PR number: UPSTREAM: 47003 for these extra changes not in upstream kube.

@derekwaynecarr
Copy link
Member

[merge][severity:blocker]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 77a6bb2

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 77a6bb2

@derekwaynecarr derekwaynecarr self-assigned this Jun 16, 2017
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2317/) (Base Commit: 4aa3720) (PR Branch Commit: 77a6bb2)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 17, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1028/) (Base Commit: 8c017d2) (PR Branch Commit: 77a6bb2) (Extended Tests: blocker) (Image: devenv-rhel7_6374)

@openshift-bot openshift-bot merged commit 3508e4a into openshift:master Jun 17, 2017
@aveshagarwal aveshagarwal deleted the master-scheduler-aggregate-errors-issue branch July 24, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants