add Limit & Limit/Request columns #16918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the "Limit" and "Limit/Request" columns seen when describing a
LimitRange to the "describe" output of projects.
**Before**
```
$ oc describe project myproject
...
Resource limits:
Name: limits
Type Resource Min Max Default
---- -------- --- --- ---
Pod cpu 200m 2 -
Pod memory 6Mi 1Gi -
Container cpu 100m 2 300m
Container memory 4Mi 1Gi 200Mi
```
**After**
```
$ oc describe project myproject
...
Resource limits:
Name: limits
Type Resource Min Max Default Limit Limit/Request
---- -------- --- --- --- ----- -------------
Pod cpu 200m 2 - - -
Pod memory 6Mi 1Gi - - -
Container cpu 100m 2 300m 300m 10
Container memory 4Mi 1Gi 200Mi 200Mi -
```
openshift-ci-robot
added
the
size/S
|
/assign fabianofranz |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabianofranz, juanvallejo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
Automatic merge from submit-queue. |
juanvallejo
deleted the
jvallejo/add-limit-limitratio-describe-project
branch
mjudeikis
pushed a commit
to mjudeikis/origin
that referenced
this pull request
Oct 26, 2017
…t-limitratio-describe-project Automatic merge from submit-queue. add Limit & Limit/Request columns Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1278683 Adds the "Limit" and "Limit/Request" columns seen when describing a LimitRange to the "describe" output of projects. **Before** ``` $ oc describe project myproject ... Resource limits: Name: limits Type Resource Min Max Default ---- -------- --- --- --- Pod cpu 200m 2 - Pod memory 6Mi 1Gi - Container cpu 100m 2 300m Container memory 4Mi 1Gi 200Mi ``` **After** ``` $ oc describe project myproject ... Resource limits: Name: limits Type Resource Min Max Default Limit Limit/Request ---- -------- --- --- --- ----- ------------- Pod cpu 200m 2 - - - Pod memory 6Mi 1Gi - - - Container cpu 100m 2 300m 300m 10 Container memory 4Mi 1Gi 200Mi 200Mi - ``` cc @openshift/cli-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1278683
Adds the "Limit" and "Limit/Request" columns seen when describing a
LimitRange to the "describe" output of projects.
Before
After
cc @openshift/cli-review