-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injecting new required vars into origin.spec file #20503
Injecting new required vars into origin.spec file #20503
Conversation
@DanyC97 this may help |
Want to review but is there some context on why this change is needed? |
@adammhaile I don't know exact context, but if someone is using tito on origin, this brings it into line with the 3.10 ose repo. The additional variables are required. It will likely result in a merge conflict which needs manual resolution. |
Centos PaaS SIG builds rpms from this repo but we've let the tito plugins which are required fall out of sync so they're running into problems. See the build.log here |
@jupierce Works for me then. |
@sdodson much thanks for digging the delta, as you know i killed 2 days trying to understand where the prob is. i wished either OCP will use same origin.spec file like everyone else in which case will force everyone to keep thigns working or at least a heads up and i'll be happy to create a PR. Sadly i can't do what @sdodson done since i have no internal access, so much thanks again for your help @sdodson |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jupierce, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We may need to just copy the contents of .tito/lib/ from OSE to Origin if there are more changes here.