Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mute project cache evaluation error #21522

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 20, 2018

When this happens, there's not really anything to do. We ought to keep track of how many bad clusterrolebindings we have (or point them out in some kind of status), but this message is super annoying.

@liggitt you were right

/assign @smarterclayton

mute that annoying, unhelpful message that is cluttering my log.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2018
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Contributor

enj commented Nov 20, 2018

RIP #17843

@deads2k
Copy link
Contributor Author

deads2k commented Nov 20, 2018

RIP #17843

heh. Say that HandleError thing would be pretty handy.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 20, 2018

/retest

@enj
Copy link
Contributor

enj commented Nov 20, 2018

RIP #17843

heh. Say that HandleError thing would be pretty handy.

One day I will get back to kubernetes/kubernetes#58307 ...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Nov 21, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7027d26 into openshift:master Nov 21, 2018
@sttts
Copy link
Contributor

sttts commented Mar 5, 2020

/cherry-pick release-3.11

@openshift-cherrypick-robot

@sttts: new pull request created: #24636

In response to this:

/cherry-pick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants