-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1879445: Add a route annotation for Samesite #25542
Bug 1879445: Add a route annotation for Samesite #25542
Conversation
@miheer: This pull request references Bugzilla bug 1879445, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test end_to_end |
/test unit |
@miheer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @frobware |
As it has been 15 days since the last CI run: /test unit |
Testing again in CI but also adding a hold as we have necessary changes in this PR to the Dockerfile that should not be commited. Those changes involve pulling in a temporary build of haproxy-1.8.26 which this change depends on. /hold |
Differences between failures in this CI which uses the new haproxy-1.8.26 RPM and a no-change PR to assert that this PR does not introduce new or different failures are (zero) :
2020/10/20 09:16:34 ci-operator version v20201015-b9bdbe6 | 2020/10/05 03:27:25 ci-operator version v20201002-9e95fb1
2020/10/20 09:16:34 Loading configuration from https://config | 2020/10/05 03:27:25 Loading configuration from https://config
2020/10/20 09:16:34 Resolved source https://github.com/opensh | 2020/10/05 03:27:25 Resolved source https://github.com/opensh
2020/10/20 09:16:34 Resolved openshift/release:golang-1.10 to | 2020/10/05 03:27:25 Resolved openshift/release:golang-1.10 to
2020/10/20 09:16:34 Resolved openshift/centos:7 to sha256:fe2 | 2020/10/05 03:27:25 Resolved openshift/centos:7 to sha256:fe2
2020/10/20 09:16:34 Using namespace https://console.build01.c | 2020/10/05 03:27:25 Using namespace https://console-openshift
2020/10/20 09:16:34 Running [input:root], src, unit | 2020/10/05 03:27:25 Running [input:root], src, unit
2020/10/20 09:16:35 Creating namespace ci-op-nl6pmbkq | 2020/10/05 03:27:25 Creating namespace ci-op-rh6hzqn9
2020/10/20 09:16:35 Creating rolebinding for user miheer in n | 2020/10/05 03:27:25 Creating rolebinding for user miheer in n
2020/10/20 09:16:35 Setting up pipeline imagestream for the t | 2020/10/05 03:27:25 Setting up pipeline imagestream for the t
2020/10/20 09:16:35 Created PDB for pods with openshift.io/bu | 2020/10/05 03:27:25 Created PDB for pods with openshift.io/bu
2020/10/20 09:16:35 Created PDB for pods with created-by-ci l | 2020/10/05 03:27:25 Created PDB for pods with created-by-ci l
2020/10/20 09:16:35 Tagging openshift/release:golang-1.10 int | 2020/10/05 03:27:25 Tagging openshift/release:golang-1.10 int
2020/10/20 09:16:35 Building src | 2020/10/05 03:27:25 Building src
2020/10/20 09:31:36 Build src succeeded after 16m38s | 2020/10/05 03:32:15 Build src succeeded after 4m50s
2020/10/20 09:31:36 Executing test unit | 2020/10/05 03:32:15 Executing test unit
2020/10/20 09:31:36 Executing pod "unit" <
[INFO] [CLEANUP] Cleaning up temporary directories [INFO] [CLEANUP] Cleaning up temporary directories
[INFO] Running `go test`... [INFO] Running `go test`...
[INFO] No compiled `gotest2junit` binary was found. Attemptin [INFO] No compiled `gotest2junit` binary was found. Attemptin
[INFO] $ hack/build-go.sh tools/gotest2junit [INFO] $ hack/build-go.sh tools/gotest2junit
++ Building go targets for linux/amd64: tools/gotest2junit ++ Building go targets for linux/amd64: tools/gotest2junit
[INFO] hack/build-go.sh exited with code 0 after 00h 00m 05s [INFO] hack/build-go.sh exited with code 0 after 00h 00m 05s
FAIL: github.com/openshift/origin/pkg/build/builder TestDocke FAIL: github.com/openshift/origin/pkg/build/builder TestDocke
FAIL: github.com/openshift/origin/pkg/build/builder TestDocke FAIL: github.com/openshift/origin/pkg/build/builder TestDocke
FAIL: github.com/openshift/origin/pkg/build/builder TestDocke FAIL: github.com/openshift/origin/pkg/build/builder TestDocke
FAIL: github.com/openshift/origin/pkg/build/builder TestPushE FAIL: github.com/openshift/origin/pkg/build/builder TestPushE
FAIL: github.com/openshift/origin/pkg/build/builder TestGetSt FAIL: github.com/openshift/origin/pkg/build/builder TestGetSt
SKIP: github.com/openshift/origin/pkg/oc/cli/admin/prune/imag SKIP: github.com/openshift/origin/pkg/oc/cli/admin/prune/imag
SKIP: github.com/openshift/origin/pkg/templateservicebroker/s SKIP: github.com/openshift/origin/pkg/templateservicebroker/s
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
[ERROR] hack/test-go.sh exited with code 1 after 01h 10m 27s | [ERROR] hack/test-go.sh exited with code 1 after 01h 11m 55s
2020/10/20 10:42:57 Container test in pod unit failed, exit c | 2020/10/05 04:45:06 Container test in pod unit failed, exit c
2020/10/20 10:42:57 Copied 2.46MB of artifacts from unit to / | 2020/10/05 04:45:06 Copied 2.44MB of artifacts from unit to /
2020/10/20 10:42:57 No custom metadata found and prow metadat | 2020/10/05 04:45:06 No custom metadata found and prow metadat
2020/10/20 10:42:58 Ran for 1h26m23s | 2020/10/05 04:45:06 Ran for 1h17m41s
error: some steps failed: error: some steps failed:
* could not run steps: step unit failed: test "unit" failed | * could not run steps: step unit failed: test "unit" failed
Container test exited with code 1, reason Error Container test exited with code 1, reason Error
--- ---
uilder TestDockerBuildError 0s uilder TestDockerBuildError 0s
FAIL: github.com/openshift/origin/pkg/build/builder TestPushE FAIL: github.com/openshift/origin/pkg/build/builder TestPushE
FAIL: github.com/openshift/origin/pkg/build/builder TestGetSt FAIL: github.com/openshift/origin/pkg/build/builder TestGetSt
SKIP: github.com/openshift/origin/pkg/oc/cli/admin/prune/imag SKIP: github.com/openshift/origin/pkg/oc/cli/admin/prune/imag
SKIP: github.com/openshift/origin/pkg/templateservicebroker/s SKIP: github.com/openshift/origin/pkg/templateservicebroker/s
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk SKIP: github.com/openshift/origin/vendor/k8s.io/kubernetes/pk
[ERROR] hack/test-go.sh exited with code 1 after 01h 10m 27s | [ERROR] hack/test-go.sh exited with code 1 after 01h 11m 55s
--- ---
time="2020-10-20T10:42:58Z" level=info msg="Reporting job sta | time="2020-10-05T04:45:06Z" level=info msg="Reporting job sta |
This is a backport of openshift/router#189 |
The build failures here look to be similar to #24874 (comment) |
e6c7e91
to
b5f2510
Compare
/lgtm |
Expecting CI failures until the new haproxy-1.8.26 is available in http://download.eng.bos.redhat.com/rcm-guest/puddles/RHAOS/AtomicOpenShift/3.11/latest/x86_64/os/Packages |
haproxy-1.8.26 brew build: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1360532 |
/test |
@miheer: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test end_to_end |
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold Waiting for #25647 It will continue to fail in CI until that merges. |
Also blocked on https://bugzilla.redhat.com/show_bug.cgi?id=1893657 |
/hold cancel #25647 merged and https://bugzilla.redhat.com/show_bug.cgi?id=1893657 was fixed by #25647. |
/retest |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@miheer: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1879445 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@stevekuznetsov: All pull requests linked via external trackers have merged: Bugzilla bug 1879445 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR openshift#25542 introduced a change that allows us to pickup a specific version of HAProxy during a CI build. Unfortunately this broke ART builds as there is no external network access that would allow access to the RPM files. This commit reflects the state of the Dockerfile as it was before 25542 merged. There is a complementary commit for ocp-build-data: openshift-eng/ocp-build-data#736 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1894011
Add a route annotation for Samesite
https://issues.redhat.com/browse/RFE-600
Bug 1879445 - SameSite hardening breaks sticky load balancing
Adding notes that the upstream PR breaks product builds and we now have an "official" way to get the latest haproxy RPM
we reverted their PR because it breaks Red Hat product builds
@jupierce @frobware