Bug 2033810: pkg: Buffer signals for abortCh #26715
Conversation
Avoid [1]: INFO[2021-12-17T19:07:56Z] Tagging openshift/release:rhel-8-release-golang-1.17-openshift-4.10 into pipeline:root. ... go vet ./... # github.com/openshift/origin/pkg/monitor pkg/monitor/cmd.go:39:2: misuse of unbuffered os.Signal channel as argument to signal.Notify # github.com/openshift/origin/pkg/test/ginkgo pkg/test/ginkgo/cmd_runsuite.go:222:2: misuse of unbuffered os.Signal channel as argument to signal.Notify which is new for Go 1.17 [2]. I'm not all that clear why the handler wants the buffering, because it seems like you could fill the buffer just as easily as you could fill an unbuffered channel. But whatever, it's easy enough to give each of these channels two slots, so Notify can catch and queue enough to get us to quickly exit without needing to block on a channel write. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26712/pull-ci-openshift-origin-master-verify/1471919425958449152 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2033810
|
@wking: This pull request references Bugzilla bug 2033810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-unspecified
|
@wking: This pull request references Bugzilla bug 2033810, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@wking: This pull request references Bugzilla bug 2033810, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-low
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2033810 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid:
which is new for Go 1.17. I'm not all that clear why the handler wants the buffering, because it seems like you could fill the buffer just as easily as you could fill an unbuffered channel. But whatever, it's easy enough to give each of these channels two slots, so
Notifycan catch and queue enough to get us to quickly exit without needing to block on a channel write.