Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use route to access prometheus instead of exec pods. #26740

Merged
merged 2 commits into from
Jan 13, 2022
Merged

use route to access prometheus instead of exec pods. #26740

merged 2 commits into from
Jan 13, 2022

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 12, 2022

This reduces the dependency chain and eliminates a source of error. Just use the route directly.

@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2022
dgrisonnet
dgrisonnet reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on green

@tkashem
Copy link
Contributor

tkashem commented Jan 12, 2022

why did we use exec pods originally, any historical context?

/lgtm

@tkashem
Copy link
Contributor

tkashem commented Jan 12, 2022

waiting for #26711 to merge first

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet dgrisonnet mentioned this pull request Jan 12, 2022
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Jan 12, 2022

alert query still work!

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26740/pull-ci-openshift-origin-master-e2e-gcp-upgrade/1481296112697479168

pushed additional commit to handle initialization without clientconfig. no longer requires updated library-go. removing hold and retagging.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed vendor-update Touching vendor dir or related files do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 12, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 12, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Jan 12, 2022

bypassing bug requirement to address CI problem from kube update

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2022

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 62769aa link false /test e2e-aws-single-node
ci/prow/e2e-aws-csi 62769aa link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c21b714 into openshift:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet left review comments

@fpetkovski fpetkovski Awaiting requested review from fpetkovski

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@tkashem tkashem

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deads2k @tkashem @openshift-bot @dgrisonnet @openshift-merge-robot