OCPBUGS-37837: vertical scaling test should not rely on CPMS replicas #28969
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-important
|
@hasbro17: This pull request references Jira Issue OCPBUGS-37837, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-etcd-scaling |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@hasbro17: This pull request references Jira Issue OCPBUGS-37837, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate ? Checking if I can aggregate the scaling job somehow (probably not). |
openshift-ci
bot
added
the
approved
|
/payload-aggregate e2e-aws-ovn-etcd-scaling |
|
/payload-aggregate e2e-aws-ovn-etcd-scaling 10 |
|
@hasbro17: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
@geliu2016: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hasbro17
force-pushed
the
scaling-test-fix
branch
from
1fe5b76
to
52738a5
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
Okay all the scaling test runs have passed. Running again to see if the scaling test flakes: /test e2e-aws-ovn-etcd-scaling |
|
/test e2e-gcp-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: 52738a5
|
|
Good enough for me. The scaling test itself is passing consistently now. The jobs trip up on the storage version migrator test but I don't think that's related to the scaling test. |
for me as well. Thanks @hasbro17 /lgtm |
|
/hold in case you want to still adjust anything |
openshift-ci
bot
added
the
do-not-merge/hold
The vertical scaling test will currently timeout on waiting for the CPMS status.readyReplicas to scale up to 4 where as in practice that may not happen. Ensuring that the cluster membership is 3 and checking that the old member has been removed is enough of a signal that vertical scaling has successfully completed
hasbro17
force-pushed
the
scaling-test-fix
branch
from
52738a5
to
f2e7297
Compare
|
Update to fix a typo and an extraneous comment. Should be the same otherwise. |
hasbro17
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, geliu2016, hasbro17, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.16 release-4.15 release-4.14 |
|
@hasbro17: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-metal-ipi-ovn-ipv6 unrelated installation issue |
|
@tjungblu: tjungblu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
then let's |
|
@hasbro17: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit ba9ac0a
into
openshift:master
|
@hasbro17: Jira Issue OCPBUGS-37837: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-37837 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hasbro17: new pull request created: #28981 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
The vertical scaling test will currently timeout on waiting for the CPMS status.readyReplicas to scale up to 4 where as in practice that may not happen. Ensuring that the cluster membership is 3 and checking that the old member has been removed is enough of a signal that vertical scaling has successfully completed.