Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.14-9.2] Consider removing ifcfg-rh config support from NetworkManager #1022

Open
travier opened this issue Sep 29, 2022 · 5 comments
Open

[4.14-9.2] Consider removing ifcfg-rh config support from NetworkManager #1022

travier opened this issue Sep 29, 2022 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@travier
Copy link
Member

travier commented Sep 29, 2022

See coreos/fedora-coreos-config#1991. We have to decide if we want to completely remove support for ifcfg-rh configs in NetworkManager in EL9 (RHCOS 9 & SCOS).

Note that right now we default to https://github.com/openshift/os/blob/master/overlay.d/05rhcos/usr/lib/NetworkManager/conf.d/10-disable-default-plugins.conf?rgh-link-date=2022-09-28T16%3A21%3A52Z and ifcfg files are no longer the default in RHEL 9: https://www.redhat.com/en/blog/rhel-9-networking-say-goodbye-ifcfg-files-and-hello-keyfiles.
@travier travier mentioned this issue Sep 29, 2022
Closed
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Sep 30, 2022
@dustymabe
tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test
db9fa35 
This test checks that the ifcfg-rh NetworkManager plugin is in
the state we expect it to be in. Some more context in:

- coreos#1993
- coreos#1991
- openshift/os#1022
@dustymabe dustymabe mentioned this issue Sep 30, 2022
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2023
@travier
Copy link
Member Author

travier commented Feb 8, 2023

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 8, 2023
@travier
Copy link
Member Author

travier commented Feb 9, 2023

/retitle [4.13-9.2] Consider removing ifcfg-rh

@openshift-ci openshift-ci bot changed the title Consider removing ifcfg-rh from EL9 [4.13-9.2] Consider removing ifcfg-rh Feb 9, 2023
@travier travier changed the title [4.13-9.2] Consider removing ifcfg-rh [4.13-9.2] Consider removing ifcfg-rh config support from NetworkManager Feb 9, 2023
@travier
Copy link
Member Author

travier commented Mar 13, 2023

It's too late to make any change for 4.13. This will have to wait for 4.14 (at least).

@travier travier changed the title [4.13-9.2] Consider removing ifcfg-rh config support from NetworkManager [4.14-9.2] Consider removing ifcfg-rh config support from NetworkManager Mar 13, 2023
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Mar 13, 2023
@dustymabe
tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test
b336013 
This test checks that the ifcfg-rh NetworkManager plugin is in
the state we expect it to be in. Some more context in:

- coreos#1993
- coreos#1991
- openshift/os#1022
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Mar 14, 2023
@dustymabe
tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test
c357ecd 
This test checks that the ifcfg-rh NetworkManager plugin is in
the state we expect it to be in. Some more context in:

- #1993
- #1991
- openshift/os#1022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test
69f630f 
This test checks that the ifcfg-rh NetworkManager plugin is in
the state we expect it to be in. Some more context in:

- coreos#1993
- coreos#1991
- openshift/os#1022
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@dustymabe @HuijingHei
tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test
1c46632 
This test checks that the ifcfg-rh NetworkManager plugin is in
the state we expect it to be in. Some more context in:

- coreos#1993
- coreos#1991
- openshift/os#1022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@openshift-bot @travier