Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Bump fedora-coreos-config #1463

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Mar 17, 2024

Created by GitHub workflow (source).

Aashish Radhakrishnan (2):
      denylist: snooze ext.config.var-mount.scsi-id on next & next-devel
      Kdump currently fails on kernel-next, for ppc64le

Dusty Mabe (2):
      manifests: add makedumpfile RPM on F41+
      manifests: remove ostree-bls.yaml

HuijingHei (1):
      tests: check default dropins file permissions

Jonathan Lebon (2):
      Add `dnf5` on Fedora 41+
      denylist: only warn if `coreos.boot-mirror` tests fail on ppc64le

Michael Armijo (2):
      denylist: extend snooze for two tests
      denylist: only denylist `coreos.boot-mirror*` on ppc64le

Timothée Ravier (1):
      manifests: Add back more wireless card firmwares

gursewak1997 (1):
      denylist: extend snooze for var-mount.scsi-id

jbtrystram (1):
      Manifests: move zram to system-configuration

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2024
@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request explicitly references no jira issue.

In response to this:

Created by GitHub workflow (source).

Dusty Mabe (1):
     manifests: add makedumpfile RPM on F41+

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from c4rt0 and prestist March 17, 2024 00:03
Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
@HuijingHei
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, coreosbot-releng, HuijingHei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Mar 20, 2024

Let's not merge these bump PRs right away, but wait until we accumulate changes, at the very least ones that affect RHCOS (which isn't the case here).

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

New changes are detected. LGTM label has been removed.

@dustymabe
Copy link
Member

/retest

@dustymabe
Copy link
Member

Thinking that #1478 should fix the CI failures.

@jbtrystram
Copy link
Contributor

jbtrystram commented Apr 10, 2024

/hold
The zram-generator pacakges break k8s :)

See coreos/fedora-coreos-config#2956

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
Aashish Radhakrishnan (2):
      denylist: snooze ext.config.var-mount.scsi-id on next & next-devel
      Kdump currently fails on kernel-next, for ppc64le

Dusty Mabe (3):
      manifests: add makedumpfile RPM on F41+
      manifests: remove ostree-bls.yaml
      image-base: drop bootfs_metadata_csum_seed entry

HuijingHei (1):
      tests: check default dropins file permissions

Jonathan Lebon (2):
      Add `dnf5` on Fedora 41+
      denylist: only warn if `coreos.boot-mirror` tests fail on ppc64le

Michael Armijo (2):
      denylist: extend snooze for two tests
      denylist: only denylist `coreos.boot-mirror*` on ppc64le

Timothée Ravier (2):
      manifests: Add back more wireless card firmwares
      tests: Verify access permissions for shadow & gshadow

gursewak1997 (1):
      denylist: extend snooze for var-mount.scsi-id

jbtrystram (1):
      Manifests: move zram to system-configuration
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@coreosbot-releng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-9-build-test-qemu e0bce83 link true /test rhcos-9-build-test-qemu
ci/prow/scos-9-build-test-qemu e0bce83 link true /test scos-9-build-test-qemu
ci/prow/rhcos-9-build-test-metal e0bce83 link true /test rhcos-9-build-test-metal
ci/prow/scos-9-build-test-metal e0bce83 link true /test scos-9-build-test-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jbtrystram
Copy link
Contributor

When this lands, please merge #1479 as well :)

@jbtrystram
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@jbtrystram
Copy link
Contributor

This won't pass CI because the zram-generator package breaks kubelet. But i can't close this PR in favor of #1479 ...
Maybe someone can do it ?

@openshift-merge-bot openshift-merge-bot bot merged commit e0bce83 into openshift:master Apr 11, 2024
2 of 7 checks passed
@travier
Copy link
Member

travier commented Apr 11, 2024

You can comment /close to pull requests to close them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants