-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump fedora-coreos-config for various fixes #480
Bump fedora-coreos-config for various fixes #480
Conversation
systemctl -q --root="$initdir" add-requires ignition-files.service "$unit" | ||
# note we `|| exit 1` here so we error out if e.g. the units are missing | ||
# see https://github.com/coreos/fedora-coreos-config/issues/799 | ||
systemctl -q --root="$initdir" add-requires ignition-files.service "$unit" || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this dracut module should technically be re-ordered to 31 at least so it's more obvious that it's after 30ignition
. Though the fact that we have || exit 1
here clearly demonstrates that it works fine.
We realized a bit late that not mounting the ESP by default currently breaks bootupd. This might not be a blocker but raising. @cgwalters? |
Specifically, - the ESP unraiding change (coreos/fedora-coreos-config#794) - working around buggy udev (coreos/fedora-coreos-config#779) - --copy-network regression (coreos/fedora-coreos-config#800) - Azure udev rules in initramfs (coreos/fedora-coreos-config#786) For the latter, also apply the same `|| exit 1` change from coreos/fedora-coreos-config#800 to our own dracut modules for good measure. ``` $ git shortlog --invert-grep --author='CoreOS Bot' 6c9f15c8857772f730cdb0b5b2df143e778c5d0d..8c07b7391473910ba3884ee0d3763743805ac78f Benjamin Gilbert (6): 40ignition-ostree: silence mkfs.xfs coreos-boot-mount-generator: stop mounting /boot/efi 40ignition-ostree: rename mount_and_restore_filesystem 40ignition-ostree: create mountpoint in mount_verbose 40ignition-ostree: add get_partlabels_for_parttype helper 40ignition-ostree: copy ESP contents as independent filesystems Dusty Mabe (1): overrides: drop graduated overrides Jonathan Lebon (7): 40ignition-ostree/transposefs: also trigger udev on by-label link mismatch for ESP 40ignition-ostree/transposefs: factor out function to restore fs 40ignition-ostree/transposefs: relabel the root of reprovisioned filesystems 40ignition-ostree/transposefs: load zram with num_devices=0 Add rawhide repo file 05core: re-order and rename some dracut modules 05core: add `|| exit 1` to `systemctl add-{requires,wants}` calls Kelvin Fan (1): overlay.d/15fcos: Stop utilizing c-l-h-m private dir Luca BRUNO (1): overrides: drop stale Afterburn entries Micah Abbott (2): use WALinuxAgent-udev package for Azure udev rules overlay: add new module for installing Azure udev rules Prashanth Sundararaman (1): tests: Enable TPM test for all arches except s390x Timothée Ravier (1): manifests/fedora-coreos-base: Mask systemd-repart ```
This overlay includes the Azure udev rules which were removed from 05core in coreos/fedora-coreos-config#786 in favour of using `WALinuxAgent-udev` instead. Though that package isn't yet in el8 (see https://bugzilla.redhat.com/show_bug.cgi?id=1913074).
5e6027a
to
5cd6441
Compare
OK, rebumped this to include coreos/fedora-coreos-config#786. Correspondingly as per coreos/fedora-coreos-config#786 (comment), also added a new |
I'll try to get it tested in Azure proper today |
@jlebon I believe we our own dracut module for the Azure udev rules here
|
Hmm, we should be inheriting that from FCOS though, right? |
You are probably right...let me clean up my repo and make sure I've got it all straight. |
I think I must have forgot to |
bootupd 0.2.5 that fixes this is built in 4.7. |
@jlebon OK, built this cleanly and confirmed that the udev rules are operating properly on Azure. Thanks for your patience. |
/approve |
Looks like this is ready for a |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Specifically,
For the latter, also apply the same
|| exit 1
change fromcoreos/fedora-coreos-config#800 to our own
dracut modules for good measure.