Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckBasicAuth does not url decode the client_id and client_secret #174

Closed
weters opened this issue Feb 20, 2018 · 2 comments
Closed

CheckBasicAuth does not url decode the client_id and client_secret #174

weters opened this issue Feb 20, 2018 · 2 comments

Comments

@weters
Copy link
Contributor

weters commented Feb 20, 2018

According to the OAuth 2.0 RFC spec, the client_id and client_secret are first separately URL encoded according to application/x-www-form-urlencoded. The CheckBasicAuth function does not properly decode these segments.
@weters weters mentioned this issue Feb 20, 2018
Merged
@weters
Copy link
Contributor Author

weters commented Feb 20, 2018

Created a pull request to address this issue: #175

@RangelReale
Copy link
Contributor

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weters @RangelReale