URL decode the client_id and client_secret in Authz header #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the OAuth2 spec (https://tools.ietf.org/html/rfc6749#section-2.3.1), the client_id and client_secret are first separately encoded using the application/x-www-form-urlencoded algorithm and then base64 encoded.
arjunrn
added a commit
to arjunrn/oauth-server
that referenced
this pull request
Mar 11, 2022
Contains the following prominent changes: 1. [Reworked redirect uri validation, resolving uri references to base url, and returning the resolved url to the requesting function](openshift/osin@06cbf43). 2. [URL decode the client_id and client_secret in Authz header](openshift/osin#175). 3. [Changing GET params to FormValue](openshift/osin#180). 4. [Ignore port when the redirect URI is a loopback address](openshift/osin#210).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OAuth2 spec
(https://tools.ietf.org/html/rfc6749#section-2.3.1), the client_id
and client_secret are first separately encoded using the
application/x-www-form-urlencoded algorithm and then base64 encoded.
#174