Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2464: Fix the golang image used for unit-tests #1299

Merged
merged 3 commits into from
Oct 18, 2022
Merged

OCPBUGS-2464: Fix the golang image used for unit-tests #1299

merged 3 commits into from
Oct 18, 2022

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Oct 7, 2022

Fix unit-test golang image and gofmt.

abhat and others added 3 commits September 29, 2022 15:33
@abhat
Fix gofmt errors on release-4.10 branch
3c73545 
There were errors in gofmt and utest with release-4.10 branch
This commit fixes the gofmt errors.

Signed-off-by: Aniket Bhat <anbhat@redhat.com>
@trozet @abhat
Allow make check without root
6cbbda4 
Skips tests that require sudo or special capabilities to execute. To
run, use "make check NOROOT=TRUE"

Signed-off-by: Tim Rozet <trozet@redhat.com>
(cherry picked from commit f72b33d)
@abhat
Update golang version and prometheus client dependency for utests
567dac1
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix the golang image used for unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@dcbw
Copy link
Contributor

dcbw commented Oct 9, 2022

/retest

1 similar comment
@dcbw
Copy link
Contributor

dcbw commented Oct 10, 2022

/retest

@dcbw
Copy link
Contributor

dcbw commented Oct 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhat abhat changed the title Fix the golang image used for unit-tests OCPBUGS-2464: Fix the golang image used for unit-tests Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-2464: Fix the golang image used for unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Jira Issue OCPBUGS-2464, which is invalid:

  • expected Jira Issue OCPBUGS-2464 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix unit-test golang image and gofmt.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Oct 17, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Jira Issue OCPBUGS-2464, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2463 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2463 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor

/label backport-risk-assessed

1 similar comment
@jcaamano
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 17, 2022
@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11a028b and 2 for PR HEAD 567dac1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022 •
edited
Loading

@abhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 567dac1 link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhat
Copy link
Contributor Author

abhat commented Oct 18, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 54f32e8 into openshift:release-4.10 Oct 18, 2022
@openshift-ci-robot
Copy link
Contributor

@abhat: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2464 has been moved to the MODIFIED state.

In response to this:

Fix unit-test golang image and gofmt.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abhat @dcbw @openshift-ci-robot @jcaamano @anuragthehatter @openshift-merge-robot @trozet